- Does the code implement the right functionality?
- Does the interface look reasonable?
- What is the proper medium to include this? (KBK is more inclined to put it in tcllib than in the Tcl Core proper.)
package provide iso8601 0.1 package require Tcl 8.5 namespace eval iso8601 { namespace export parse_date parse_time # Enumerate the patterns that we recognize for an ISO8601 date as both # the regexp patterns that match them and the [clock] patterns that scan # them. variable DatePatterns { {\d\d\d\d-\d\d-\d\d} {%Y-%m-%d} {\d\d\d\d\d\d\d\d} {%Y%m%d} {\d\d\d\d-\d\d\d} {%Y-%j} {\d\d\d\d\d\d\d} {%Y%j} {\d\d-\d\d-\d\d} {%y-%m-%d} {\d\d\d\d\d\d} {%y%m%d} {\d\d-\d\d\d} {%y-%j} {\d\d\d\d\d} {%y%j} {--\d\d-\d\d} {--%m-%d} {--\d\d\d\d} {--%m%d} {--\d\d\d} {--%j} {---\d\d} {---%d} {\d\d\d\d-W\d\d-\d} {%G-W%V-%u} {\d\d\d\dW\d\d\d} {%GW%V%u} {\d\d-W\d\d-\d} {%g-W%V-%u} {\d\dW\d\d\d} {%gW%V%u} {-W\d\d-\d} {-W%V-%u} {-W\d\d\d} {-W%V%u} {-W-\d} {%u} } # MatchTime -- (constructed procedure) # # Match an ISO8601 date/time string and indicate how it matched. # # Parameters: # string -- String to match. # fieldArray -- Name of an array in caller's scope that will receive # parsed fields of the time. # # Results: # Returns 1 if the time was scanned successfully, 0 otherwise. # # Side effects: # Initializes the field array. The keys that are significant: # - Any date pattern in 'DatePatterns' indicates that the # corresponding value, if non-empty, contains a date string # in the given format. # - The patterns T, Hcolon, and Mcolon indicate a literal # T preceding the time, a colon following the hour, or # a colon following the minute. # - %H, %M, %S, and %Z indicate the presence of the # corresponding parts of the time. proc init {} { variable DatePatterns set cmd {regexp -expanded -nocase -- {PATTERN} $timeString ->} set re \(?:\(?: set sep {} foreach {regex interpretation} $DatePatterns { append re $sep \( $regex \) append cmd " " [list field($interpretation)] set sep | } append re \) {(T|[[:space:]]+)} \)? append cmd { field(T)} append re {(\d\d)(?:(:?)(\d\d)(?:(:?)(\d\d)))} append cmd { field(%H) field(Hcolon) } \ {field(%M) field(Mcolon) field(%S)} append re {[[:space:]]*(Z|[-+]\d\d\d\d)?} append cmd { field(%Z)} set cmd [string map [list {{PATTERN}} [list $re]] \ $cmd] proc MatchTime { timeString fieldArray } " upvar 1 \$fieldArray field $cmd " } init rename init {} } # iso8601::parse_date -- # # Parse an ISO8601 date/time string in an unknown variant. # # Parameters: # string -- String to parse # args -- Arguments as for [clock scan]; may include any of # the '-base', '-gmt', '-locale' or '-timezone options. # # Results: # Returns the given date in seconds from the Posix epoch. proc iso8601::parse_date { string args } { variable DatePatterns foreach { regex interpretation } $DatePatterns { if { [regexp "^$regex\$" $string] } { return [eval [linsert $args 0 \ clock scan $string -format $interpretation]] } } return -code error "not an iso8601 date string" } # iso8601::parse_time -- # # Parse a point-in-time in ISO8601 format # # Parameters: # string -- String to parse # args -- Arguments as for [clock scan]; may include any of # the '-base', '-gmt', '-locale' or '-timezone options. # # Results: # Returns the given time in seconds from the Posix epoch. proc iso8601::parse_time { timeString args } { variable DatePatterns MatchTime $timeString field set pattern {} foreach {regex interpretation} $DatePatterns { if { $field($interpretation) ne {} } { append pattern $interpretation } } append pattern $field(T) if { $field(%H) ne {} } { append pattern %H $field(Hcolon) if { $field(%M) ne {} } { append pattern %M $field(Mcolon) if { $field(%S) ne {} } { append pattern %S } } } if { $field(%Z) ne {} } { append pattern %Z } return [eval [linsert $args 0 clock scan $timeString -format $pattern]] } # Usage examples if { [info exists ::argv0] && ( $::argv0 eq [info script] ) } { puts "iso8601::parse_date" puts [iso8601::parse_date 1970-01-02 -timezone :UTC] puts [iso8601::parse_date 1970-W01-5 -timezone :UTC] puts [time {iso8601::parse_date 1970-01-02 -timezone :UTC} 1000] puts [time {iso8601::parse_date 1970-W01-5 -timezone :UTC} 1000] puts "iso8601::parse_time" puts [clock format [iso8601::parse_time 2004-W33-2T18:52:24Z] \ -format {%X %x %z} -locale system] puts [clock format [iso8601::parse_time 18:52:24Z] \ -format {%X %x %z} -locale system] puts [time {iso8601::parse_time 2004-W33-2T18:52:24Z} 1000] puts [time {iso8601::parse_time 18:52:24Z} 1000] }
de: To say it again in public I think, the new 8.5 clock scanning capabilities are a great feature. Thanks a lot, kbk! That iso 8601 scanner (I take my hat off to you that you tend to do really the whole job) is an important piece on top of the new clock functionality. Though, it does currently support only a part of the so-called extended format. Example:
iso8601::parse_time 1985-04-12T10:15:30+04returns the error "input string does not match supplied format" (the example date is out of the ISO 8601:1997, 5.4.1. Just checked: 8601:2000 still has the same example).KBK Congratulations, you found a bug in the [clock scan] implementation. Fixed in tcl/generic/clock.tcl,v 1.12.
I think I've found a related bug in your script (nice work though).iso8601::parse_time 1985-04-12T10:15:30+04:00returns the error "input string does not match supplied format". I got the format from the W3 link (and it's what our customer uses, we're having fun with Tcl8.4 and trying to clock scan this). It seems the regexp for detecting a timezone is expecting 4 digits without a colon?
append re {[[:space:]]*(Z|[-+]\d\d\d\d)?}should this be
append re {[[:space:]]*(Z|[-+]\d\d:\d\d)?}or have I goofed? -- DC --On second thoughts, if I use
append re {[[:space:]]*(Z|[-+]\d\d:?(\d\d)?)?}It allows a TZ of +04:00, +0400 or +04 (which I think is right according to ISO). -- DC --
LV So, is the above code going to appear in Tcl 8.5, or tcllib 2.0 (or whatever the next tcllib release version is?]
Some web pages discussing the ISO standard follow. I was hoping to find a set of test data that could be used in the tcl test suite.
- http://www.hackcraft.net/web/datetime/
- http://www.merlyn.demon.co.uk/datefmts.htm
- http://www.hermetic.ch/cal_stud/newman.htm
- http://www.w3.org/TR/NOTE-datetime
- http://www.w3.org/QA/Tips/iso-date
- http://www.cl.cam.ac.uk/~mgk25/iso-time.html
- http://www.mcs.vuw.ac.nz/technical/software/SGML/doc/iso8601/ISO8601.html
- http://www.cs.tut.fi/~jkorpela/iso8601.html
- http://www.uic.edu/depts/accc/software/isodates/isocontents.html
- http://www.iso.org/iso/en/prods-services/popstds/datesandtime.html
See also: Parsing RFC2822 dates and times